Skip to content
Snippets Groups Projects
Commit f0a31d43 authored by Tamas Kiss's avatar Tamas Kiss
Browse files

Fixing refactoring errors

parent c36f6a94
No related branches found
No related tags found
No related merge requests found
...@@ -26,7 +26,7 @@ tests_require = [ ...@@ -26,7 +26,7 @@ tests_require = [
setup( setup(
name='sentry-auth-authsch', name='sentry-auth-authsch',
version='1.0.0', version='1.0.1',
author='Tamas Kiss', author='Tamas Kiss',
author_email='tamas.kiss@kszk.bme.hu', author_email='tamas.kiss@kszk.bme.hu',
url='https://github.com/thomasklein94/sentry-auth-authsch.git', url='https://github.com/thomasklein94/sentry-auth-authsch.git',
......
...@@ -8,9 +8,8 @@ if django.VERSION[:2] >= (1, 8): ...@@ -8,9 +8,8 @@ if django.VERSION[:2] >= (1, 8):
default_app_config = "sentry_auth_authsch.apps.Config" default_app_config = "sentry_auth_authsch.apps.Config"
else: else:
# Provide backwards compatibility. # Provide backwards compatibility.
from sentry import auth, options from sentry import auth
from .provider import AuthSCHProvider from .provider import AuthSCHProvider
auth.register('authsch', AuthSCHProvider) auth.register('authsch', AuthSCHProvider)
...@@ -7,9 +7,8 @@ class Config(AppConfig): ...@@ -7,9 +7,8 @@ class Config(AppConfig):
name = "sentry_auth_authsch" name = "sentry_auth_authsch"
def ready(self): def ready(self):
from sentry import auth, options from sentry import auth
from .provider import AuthSCHProvider from .provider import AuthSCHProvider
auth.register("authsch", AuthSCHProvider) auth.register("authsch", AuthSCHProvider)
...@@ -45,7 +45,7 @@ class AuthSCHProvider(OAuth2Provider): ...@@ -45,7 +45,7 @@ class AuthSCHProvider(OAuth2Provider):
] ]
def get_refresh_token_url(self): def get_refresh_token_url(self):
return self.access_token_endpoint return self.access_token_url
def build_identity(self, state): def build_identity(self, state):
data = state["data"] data = state["data"]
......
...@@ -5,7 +5,6 @@ import logging ...@@ -5,7 +5,6 @@ import logging
import requests import requests
from sentry.auth.view import AuthView, ConfigureView from sentry.auth.view import AuthView, ConfigureView
from string import maketrans
from .constants import ERR_INVALID_RESPONSE, PROFILE_ENDPOINT from .constants import ERR_INVALID_RESPONSE, PROFILE_ENDPOINT
logger = logging.getLogger("sentry.auth.authsch") logger = logging.getLogger("sentry.auth.authsch")
......
...@@ -48,3 +48,19 @@ class AuthSCHProviderTest(TestCase): ...@@ -48,3 +48,19 @@ class AuthSCHProviderTest(TestCase):
with pytest.raises(IdentityNotValid): with pytest.raises(IdentityNotValid):
provider.refresh_identity(auth_identity) provider.refresh_identity(auth_identity)
def test_get_refresh_token_url_noexc(self):
provider = self.auth_provider.get_provider()
provider.get_refresh_token_url()
def test_get_auth_pipeline_noexc(self):
provider = self.auth_provider.get_provider()
provider.get_auth_pipeline()
def test_get_client_id_noexc(self):
provider = self.auth_provider.get_provider()
provider.get_client_id()
def test_get_client_secret_noexc(self):
provider = self.auth_provider.get_provider()
provider.get_client_secret()
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment