From f0a31d4357a681b02acc310b046f174a7fd3341b Mon Sep 17 00:00:00 2001
From: Tamas Kiss <tamas.kiss@kszk.bme.hu>
Date: Thu, 26 Dec 2019 22:01:03 +0100
Subject: [PATCH] Fixing refactoring errors
---
setup.py | 2 +-
src/sentry_auth_authsch/__init__.py | 3 +--
src/sentry_auth_authsch/apps.py | 3 +--
src/sentry_auth_authsch/provider.py | 2 +-
src/sentry_auth_authsch/views.py | 1 -
tests/test_provider.py | 16 ++++++++++++++++
6 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/setup.py b/setup.py
index e9fb06e..a187d70 100644
--- a/setup.py
+++ b/setup.py
@@ -26,7 +26,7 @@ tests_require = [
setup(
name='sentry-auth-authsch',
- version='1.0.0',
+ version='1.0.1',
author='Tamas Kiss',
author_email='tamas.kiss@kszk.bme.hu',
url='https://github.com/thomasklein94/sentry-auth-authsch.git',
diff --git a/src/sentry_auth_authsch/__init__.py b/src/sentry_auth_authsch/__init__.py
index 667a72c..82ab6d8 100644
--- a/src/sentry_auth_authsch/__init__.py
+++ b/src/sentry_auth_authsch/__init__.py
@@ -8,9 +8,8 @@ if django.VERSION[:2] >= (1, 8):
default_app_config = "sentry_auth_authsch.apps.Config"
else:
# Provide backwards compatibility.
- from sentry import auth, options
+ from sentry import auth
from .provider import AuthSCHProvider
auth.register('authsch', AuthSCHProvider)
-
diff --git a/src/sentry_auth_authsch/apps.py b/src/sentry_auth_authsch/apps.py
index d114e80..e7b5143 100644
--- a/src/sentry_auth_authsch/apps.py
+++ b/src/sentry_auth_authsch/apps.py
@@ -7,9 +7,8 @@ class Config(AppConfig):
name = "sentry_auth_authsch"
def ready(self):
- from sentry import auth, options
+ from sentry import auth
from .provider import AuthSCHProvider
auth.register("authsch", AuthSCHProvider)
-
diff --git a/src/sentry_auth_authsch/provider.py b/src/sentry_auth_authsch/provider.py
index f1a4a0e..2a6e391 100644
--- a/src/sentry_auth_authsch/provider.py
+++ b/src/sentry_auth_authsch/provider.py
@@ -45,7 +45,7 @@ class AuthSCHProvider(OAuth2Provider):
]
def get_refresh_token_url(self):
- return self.access_token_endpoint
+ return self.access_token_url
def build_identity(self, state):
data = state["data"]
diff --git a/src/sentry_auth_authsch/views.py b/src/sentry_auth_authsch/views.py
index bd20bc1..5bae169 100644
--- a/src/sentry_auth_authsch/views.py
+++ b/src/sentry_auth_authsch/views.py
@@ -5,7 +5,6 @@ import logging
import requests
from sentry.auth.view import AuthView, ConfigureView
-from string import maketrans
from .constants import ERR_INVALID_RESPONSE, PROFILE_ENDPOINT
logger = logging.getLogger("sentry.auth.authsch")
diff --git a/tests/test_provider.py b/tests/test_provider.py
index 805be64..9b1d821 100644
--- a/tests/test_provider.py
+++ b/tests/test_provider.py
@@ -48,3 +48,19 @@ class AuthSCHProviderTest(TestCase):
with pytest.raises(IdentityNotValid):
provider.refresh_identity(auth_identity)
+
+ def test_get_refresh_token_url_noexc(self):
+ provider = self.auth_provider.get_provider()
+ provider.get_refresh_token_url()
+
+ def test_get_auth_pipeline_noexc(self):
+ provider = self.auth_provider.get_provider()
+ provider.get_auth_pipeline()
+
+ def test_get_client_id_noexc(self):
+ provider = self.auth_provider.get_provider()
+ provider.get_client_id()
+
+ def test_get_client_secret_noexc(self):
+ provider = self.auth_provider.get_provider()
+ provider.get_client_secret()
--
GitLab