Memory leak fixed, at creating server threads.

By Kiss Adam

.gitignore

 semmodbus
+semmodbus_server.layout

devices/jelenletjelzo.cpp

@@ -4,15 +4,15 @@ void jelenletjelzo::poll(modbus_t* modbus){
     modbus_flush(modbus); //Flush modbus buffers
     modbus_set_slave(modbus, 1); //Set slave address to 1
 
-    uint16_t asd;
+    uint16_t buff;
 
-    if (modbus_read_input_registers(modbus, 0x00, 1, &asd) == -1) { //read  1 (third arg) input register, from register index 0(sec arg), to the address of asd
+    if (modbus_read_input_registers(modbus, 0x00, 1, &buff) == -1) { //read  1 (third arg) input register, from register index 0(sec arg), to buff
         fprintf(stderr, "Error %d while reading: %s\n", errno, modbus_strerror(errno));
         return;
     }
 
     m.lock(); //lock semaphore
-    stat = asd&(1<<7); //set stat
+    stat = buff&(1<<7); //set stat
     m.unlock(); //unlock
 }
 

socket_listener.cpp

@@ -49,7 +49,7 @@ void serveConnect(Socket s){
         for(auto* i: Devices){
             if(i->getName()==req_device){
                 found = true;
-                std::stringstream ss; ///TODO: clear the code, skip stringstream
+                std::stringstream ss; ///TODO: clean the code, skip stringstream
                 ss << i->getResp(json_request);
                 std::string ans= ss.str();
 
@@ -91,8 +91,6 @@ void SocketListener(){
 	std::cout << "Socket Listener thread started\n\n";
 	std::set_terminate(socket_thread_terminator);
 
-    std::list<std::thread*> Connects;
-
     int portno;
     Socket accpeted;
     socklen_t clilen;
@@ -126,6 +124,7 @@ void SocketListener(){
         if (accpeted < 0) {
              perror("ERROR on accept");
         }
-        Connects.push_back(new std::thread(serveConnect, accpeted)); ///TODO: fix memory leak
+        std::thread serving_thread (serveConnect, accpeted);
+		serving_thread.detach();
     }
 }