From dc0ed87e141c4633848e2f5fed24f33256190885 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bodn=C3=A1r=20Zsombor?= <bodzsoaa@sch.bme.hu>
Date: Sun, 21 Feb 2021 16:29:14 +0100
Subject: [PATCH] Use constexpr for protocol_type_
---
src/configuration.cc | 4 ++--
src/configuration.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/configuration.cc b/src/configuration.cc
index 447d273..af35006 100644
--- a/src/configuration.cc
+++ b/src/configuration.cc
@@ -4,6 +4,7 @@
namespace {
constexpr quint8 kRgbByteSize{3};
+constexpr quint8 kProtocolType{2};
} // namespace
// TODO check, variable types
@@ -24,7 +25,7 @@ qint32 Configuration::width() const { return width_; }
qint32 Configuration::height() const { return height_; }
-quint8 Configuration::protocol_type() const { return protocol_type_; }
+quint8 Configuration::protocol_type() const { return kProtocolType; }
quint32 Configuration::packet_header_size() const {
return packet_header_size_;
@@ -81,7 +82,6 @@ void Configuration::LoadSettings() {
// Network protocol specific constants
settings_.beginGroup("network");
- protocol_type_ = 2;
broadcast_animation_port_ =
settings_.value("broadcast_animation_port", 10000).toUInt();
diff --git a/src/configuration.h b/src/configuration.h
index 15d22b6..abe65ed 100644
--- a/src/configuration.h
+++ b/src/configuration.h
@@ -60,7 +60,6 @@ class Configuration : public QObject {
qint32 width_;
qint32 height_;
//
- quint8 protocol_type_;
quint32 window_byte_size_;
quint32 max_windows_per_datagram_;
quint32 packet_header_size_;
--
GitLab